Test deploy#995
Conversation
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, but you need to add your DEMO LINK to the PR description. Also, you need to pass all tests and linter checks before requesting the review
|
I've started to work on react components and finalized the main page. May I ask you to take a look and let me know if this approach is workable or I have to fix something? |
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Looks good for implemented page, but can't review as there are no details page, phones, accessories, tablet, also no favicon and favourites page looks broken:
Also, let's pass all tests and specially linter checks.
|
I did full app, but when I'm running the tests It's passing only one and I can't see rest of the teste (if any). May I ask you to ckeck it please? https://friranger1.github.io/react_phone-catalog/#/ 
|
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
good job, but there are few things to fix:
- this section should link to the relevant pages
- these values should be stored in the search parameters so that, after the page has been reloaded, the filters will be the same
- make sure these numbers are the same
- it should link to the product page
-
After refreshing the page, the product should remain in the cart and favourites, but your solution does not save it there
-
the footer should not stretch
|
Please take a look |
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Good progress, check next:
- Footer should be sticky at the bottom of the page:
-
Add the favicon.
-
When I select something in "You may also like" section, the page should smoothly scrolls to top.
-
Add some handle logic on checkout:
- Slider should has different images:
- "Order Now" button should redirect to existing resource:
3 participants
No description provided.